Re: [PATCH] md5: accepts a new --threads option (original) (raw)

[Top][All Lists]


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Eric Blake
Subject: Re: [PATCH] md5: accepts a new --threads option
Date: Thu, 22 Oct 2009 05:58:28 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

According to Pádraig Brady on 10/22/2009 5:09 AM:

digest routines in gnulib do fread(4096). Bumping that up to 32KiB gives a 3% boost.

Well spotted.

Does anyone have any objections to increasing the stack requirement by 28672 bytes?

None here - support for a stack of at least 1 megabyte is very common these days. And the faster I/O speed justifies it.


Don't work too hard, make some time for fun as well!

Eric Blake address@hidden -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrgSOMACgkQ84KuGfSFAYDqSQCglK6SdA8wPtW4N08EXVJuyhhE c+wAnibe4hVgP+bCkaE7s8PIma5u7cjU =+zt6 -----END PGP SIGNATURE-----