Re: pending patches? (original) (raw)

[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

From: Eric Blake
Subject: Re: pending patches?
Date: Sat, 14 Nov 2009 06🔞24 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

According to Jim Meyering on 11/14/2009 12:20 AM:

Eventually, it'd be good to factor out your nap function definition, maybe into a module. There is already one copy in test-stat-time.c, and this patch adds two more. I presume they're all identical.

I thought about that. They weren't quite identical, in that they need to know what file name to probe without interfering with other parallel tests. I also plan to use both test-chown.h and test-lchown.h from within the soon-to-appear test-fchownat.c, so yes, some factoring would be nice.

I'm also thinking of adding a usleep module to guarantee Linux semantics (usleep(1000000) waits a second, rather than failing instantly with EINVAL). That will clean up its use somewhat.

Don't work too hard, make some time for fun as well!

Eric Blake address@hidden -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkr+rh8ACgkQ84KuGfSFAYBNZACguhUPEcpOaj5gsfv7tLVs7edg yH0Anj32tFC8MfEwUkmxXu95MMPkF6By =695y -----END PGP SIGNATURE-----