[llvm-dev] Should functions returning bool return true or false on success? (original) (raw)
Nico Weber via llvm-dev llvm-dev at lists.llvm.org
Mon Sep 17 10:57:40 PDT 2018
- Previous message: [llvm-dev] RFC: PassManager extensions
- Next message: [llvm-dev] Should functions returning bool return true or false on success?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
in https://reviews.llvm.org/D52143 there's some uncertainty if LLVM code prefers
if (!Function()) // Call to function failed, deal with it
or
if (Function()) // Call to function failed, deal with it
(Note that this is about functions returning bool, not int.)
Folks on that review feel that returning true on success is probably what we want, but it's not documented anywhere and we do have both forms in the codebase.
True on success seems more common: http://llvm-cs.pcc.me.uk/?q=true+on+success http://llvm-cs.pcc.me.uk/?q=true+on+error
Does anyone have a pointer to previous on-list discussion on this? If not, this thread could be the place where we sort this out once and for all :-)
Apologies for the bike-sheddy topic.
Nico -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180917/b2502481/attachment.html>
- Previous message: [llvm-dev] RFC: PassManager extensions
- Next message: [llvm-dev] Should functions returning bool return true or false on success?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]