[llvm-dev] State of llgo in monorepo? (original) (raw)

Doerfert, Johannes via llvm-dev llvm-dev at lists.llvm.org
Mon Feb 10 12:12:21 PST 2020

Do we still need these: https://llvm.org/docs/CodingStandards.html#guidelines-for-go-code

Johannes Doerfert Researcher

Argonne National Laboratory Lemont, IL 60439, USA

jdoerfert at anl.gov

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org> Sent: Monday, February 10, 2020 12:12 To: Peter Collingbourne Cc: llvm-dev; Peter Collingbourne; Andrew Wilkins Subject: Re: [llvm-dev] State of llgo in monorepo?

Done thusly:

echristo at athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git 936d1427da1..372bfc65deb master -> master

On Mon, Feb 10, 2020 at 10:02 AM Eric Christopher <echristo at gmail.com<mailto:echristo at gmail.com>> wrote: OK. I'll get it.

-eric

On Mon, Feb 10, 2020 at 9:58 AM Peter Collingbourne <peter at pcc.me.uk<mailto:peter at pcc.me.uk>> wrote: Sure, that's fine with me.

Peter

On Mon, Feb 10, 2020 at 9:57 AM Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Calling pcc real fast :)

-eric

On Mon, Feb 10, 2020 at 9:49 AM David Blaikie via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Yep - delete it. If someone wants it back they can resurrect it from version control & explain why it's worth adding back in.

On Mon, Feb 10, 2020 at 9:17 AM Jonas Devlieghere via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Thanks for bringing this up! Strong +1 from me for all the reasons you've mentioned.

On Mon, Feb 10, 2020 at 8:42 AM Raphael Isemann via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:

Hi all, the monorepo contains a Go frontend called 'llgo' (in the llgo/ top level folder). It apparently hasn't been active since 2017 and before that it wasn't very active either (there were 13 commits in 2016 apparently, most of it minor fixes). I would propose that we remove it from the monorepo for the following reasons: * It is apparently unmaintained. * It only supports a long outdated Go version (1.5 while latest is 1.13 or so). * It doesn't build (at least on my machine) due to runtime errors (the build log is really unhelpful in telling me what actually went wrong). In general the build system is kinda flawed as it seems to just manually run 'make' as a single custom build step (even with a -GNinja build). * It contains a full copy of Mark Twain's novel "The Adventures of Tom Sawyer". It gets really tiring to blacklist this file on my desktop search engine as it otherwise constantly comes up in unrelated searches for words that are by accident in this novel. * The sources of multiple third party libraries are copied into its third party directory. It would be nice not to have random code in the LLVM repo under a different license than LLVM. * It's the only reason why we maintain some Go support in LLVM's CMake (like llvmaddgoexecutable ). Thoughts? - Raphael

LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

--

Peter

More information about the llvm-dev mailing list