[llvm-dev] [llvm-commits at lists.llvm.org: Re: [llvm] 2dea3f1 (original) (raw)

[llvm-dev] [llvm-commits at lists.llvm.org: Re: [llvm] 2dea3f1 - [SVE] Add new VectorType subclasses]

James Y Knight via llvm-dev llvm-dev at lists.llvm.org
Wed May 13 07:32:42 PDT 2020

Agreed. Those llvm-c changes are wrong, and compatibility needs to be maintained for the numeric values at minimum. Probably also would be a good idea to make LLVMVectorTypeKind a deprecated alias for LLVMFixedVectorTypeKind.

On Wed, May 13, 2020 at 9:11 AM Joerg Sonnenberger via llvm-dev < llvm-dev at lists.llvm.org> wrote:

Bringing this up on llvm-dev for more general attention.

The problem here is two fold: (1) Reuse of enumeration values is just a major no-go. (2) I'm not sure why the existing vector types had to be killed completely. But something clearly has to be done here. This majorly affects e.g. Mesa. Joerg ----- Forwarded message from Joerg Sonnenberger via llvm-commits <_ _llvm-commits at lists.llvm.org> ----- Date: Sun, 10 May 2020 02:34:12 +0200 From: Joerg Sonnenberger via llvm-commits <llvm-commits at lists.llvm.org> To: Christopher Tetreault <ctetreau at quicinc.com>, Christopher Tetreault <_ _llvmlistbot at llvm.org> Cc: llvm-commits at lists.llvm.org Subject: Re: [llvm] 2dea3f1 - [SVE] Add new VectorType subclasses Reply-To: Joerg Sonnenberger <joerg at bec.de> On Wed, Apr 22, 2020 at 08:59:20AM -0700, Christopher Tetreault via llvm-commits wrote: > > Author: Christopher Tetreault > Date: 2020-04-22T08:59:01-07:00 > New Revision: 2dea3f129878e929e5d1f00b91a622eb1ec8be4e > > URL: https://github.com/llvm/llvm-project/commit/2dea3f129878e929e5d1f00b91a622eb1ec8be4e > DIFF: https://github.com/llvm/llvm-project/commit/2dea3f129878e929e5d1f00b91a622eb1ec8be4e.diff > > LOG: [SVE] Add new VectorType subclasses This seems to have basically broken both ABI and API of llvm-c. Joerg

llvm-commits mailing list llvm-commits at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

----- End forwarded message -----

LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200513/ef0360d2/attachment.html>

More information about the llvm-dev mailing list