[PATCH] Properly (.hg)ignore the JTwork and JTreport directories (original) (raw)
David Holmes david.holmes at oracle.com
Sun Jun 30 22:30:14 UTC 2019
- Previous message: [PATCH] Properly (.hg)ignore the JTwork and JTreport directories
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 30/06/2019 10:22 pm, Jaikiran Pai wrote:
Hello David,
On 30/06/19 11:03 AM, David Holmes wrote: Hi Jaikiran,
On 29/06/2019 5:16 am, Jaikiran Pai wrote: Can I please get a review and a sponsor for this patch[1] which fixes the .hgignore file to take into account the JTreport and JTwork directories that can reside at the root of the repository. I don't see any problem with current settings. I wonder if it is hg version specific? That's possible. I am on macOS (10.14.1) with mercurial version at 4.3.1: hg --version Mercurial Distributed SCM (version 4.3.1) (see https://mercurial-scm.org for more information) I will upgrade to latest release of mercurial and see if it changes anything.
I'm actually downrev at 3.4.2, on Linux.
David
-Jaikiran
> hg status -i | grep "I JT" I JTwork/error.html But this patch doesn't seem to cause me any problems either. David -----
In its current form (without this patch), if I have these directories at the root of my repo, then these aren't being ignored. I see output like below for commands like "hg st":
$> hg st ? JTreport/html/config.html ? JTreport/html/env.html ? JTreport/html/error.html ? JTreport/html/errorgr.html ? JTreport/html/excluded.html ? JTreport/html/failed.html ... ? JTwork/classes/0/java/net/httpclient/ALPNFailureTest.d/ALPNFailureTest$ReadOnlyServer.class ? JTwork/classes/0/java/net/httpclient/ALPNFailureTest.d/ALPNFailureTest.class ? JTwork/classes/0/java/net/httpclient/ALPNProxyFailureTest.d/ALPNFailureTest$ReadOnlyServer.class ? JTwork/classes/0/java/net/httpclient/ALPNProxyFailureTest.d/ALPNFailureTest.class
... With the proposed patch, these directories are correctly ignored. With this patch, I also tested that similar directories which are within sub-directories of the repo are ignored too, by running arbitrary jtreg tests to generate such directories at different locations. The change in that patch uses the "glob" syntax noted in [2] to properly exclude these directories. I haven't explicitly tested it for the ".git" directory being ignored in that list, but I expect the change is needed for that directory too and hence decided to include it in the patch. I'm a bit new to the contribution process and don't know if changes like these need a JBS issue to be created. If it's needed, I can create one and regenerate a webrev to reference it. So please do let me know. FWIW, I am on: hg --version Mercurial Distributed SCM (version 4.3.1) (see https://mercurial-scm.org for more information) [1] http://cr.openjdk.java.net/~jpai/webrev/hgignore-patch/webrev/ [2] https://www.selenic.com/mercurial/hgignore.5.html -Jaikiran
- Previous message: [PATCH] Properly (.hg)ignore the JTwork and JTreport directories
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]