[python-committers] Dismiss review if a PR is modified (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Tue Jul 18 21:10:25 EDT 2017
- Previous message (by thread): [python-committers] Dismiss review if a PR is modified
- Next message (by thread): [python-committers] GitHub blog post on managing email notifications
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 19 July 2017 at 09:37, Victor Stinner <victor.stinner at gmail.com> wrote:
Oh.
For backports, it's convenient to be able to merge without a review. I see many cores doing it and I like it. For master, I don't know. Sometimes a PR is merged too fast, sometiles nobody reviews a PR even if it's good. So for the master branch, the dev takes its own responsability to merge ;-)
Right, "review required" settings can be useful, but they genuinely require a self-review option as an escape hatch in community projects, and GitHub doesn't currently offer that (it doesn't allow self-review at all, not even to mark your own PRs as still requiring further changes).
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message (by thread): [python-committers] Dismiss review if a PR is modified
- Next message (by thread): [python-committers] GitHub blog post on managing email notifications
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]