[python-committers] Dismiss review if a PR is modified (original) (raw)
R. David Murray rdmurray at bitdance.com
Wed Jul 19 11🔞40 EDT 2017
- Previous message (by thread): [python-committers] Dismiss review if a PR is modified
- Next message (by thread): [python-committers] Dismiss review if a PR is modified
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, 18 Jul 2017 23:13:41 -0000, Brett Cannon <brett at python.org> wrote:
Do realize that setting is part of requiring a review for pull requests: https://help.github.com/articles/enabling-required-reviews-for-pull-requests/. So in order to get this we would require all PRs, core dev or not, to receive an approving review from another core developer (I don't think an approving review from just anyone counts towards the minimum approval). There might be around this, but it will require some testing to make sure (see https://github.com/python/core-workflow/issues/94#issuecomment-316224864).
Ah, I thought we were already doing that, but of course we aren't. Nevermind :)
--David
- Previous message (by thread): [python-committers] Dismiss review if a PR is modified
- Next message (by thread): [python-committers] Dismiss review if a PR is modified
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]