[python-committers] Revert changes which break too many buildbots (original) (raw)
Ethan Furman ethan at stoneleaf.us
Wed Jun 14 20:35:04 EDT 2017
- Previous message (by thread): [python-committers] Revert changes which break too many buildbots
- Next message (by thread): [python-committers] Revert changes which break too many buildbots
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 06/14/2017 02:07 PM, Donald Stufft wrote:
I’m +1 on reverting the change, I’d even go so far to say I’d be +1 on doing it as a first response. It’s always possible to revert the revert once the person who committed the patch has time to investigate the failure and recommit the patch with a fix.
I would rather have the revert be the first response. Without a thorough understanding of the bug/feature being addressed it is entirely possible to introduce a new bug or change the semantics of the original patch.
--
Ethan
- Previous message (by thread): [python-committers] Revert changes which break too many buildbots
- Next message (by thread): [python-committers] Revert changes which break too many buildbots
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]