[python-committers] Travis now checks for whitespace issues in PRs (original) (raw)

Victor Stinner victor.stinner at gmail.com
Wed Jun 28 12:09:04 EDT 2017

FYI PC/pyconfig.h couldn't be modified in the master branch, because it contains tabs. See https://github.com/python/cpython/pull/2476 failure. I created https://github.com/python/cpython/pull/2477 which contains a "make patchcheck" run to reformat PC/pyconfig.h.

Maybe we should fix spaces of all files in all branches to prevent such annoying issue?

Victor

2017-06-25 3:05 GMT+02:00 Brett Cannon <brett at python.org>:

I just pushed a change to master, 3.6, and 3.5 where Tools/scripts/patchcheck.py now has a --travis option which will run the whitespace fixers from make patchcheck but trigger a Travis build failure if any changes were necessary. This only runs on Linux so it is a PR blocker, but also so it isn't done more than once per PR.

This was not backported to 2.7 because I honestly didn't want to do the work to fix the merge conflicts.

python-committers mailing list python-committers at python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/

More information about the python-committers mailing list