[python-committers] AppVeyor is now required to pass on PRs (original) (raw)
Victor Stinner victor.stinner at gmail.com
Thu Jan 25 16:31:58 EST 2018
- Previous message (by thread): [python-committers] AppVeyor is now required to pass on PRs
- Next message (by thread): [python-committers] AppVeyor is now required to pass on PRs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
The best would be able to have a bot merging a pull request once tests pass and a core developer asked a merge. I'm not talking about the current approval using review, but something new, like adding a special comment like "Merge". Such comment would only merge if it's written by a core developer.
Each time I approve a backport PR created by miss-ilington with "LGTM, good bot", I hope secretly that the PR will be merged automatically once CI tests pass ;-)
Is it possible to write a bot which merges a PR?
Victor
2018-01-25 20:04 GMT+01:00 Mariatta Wijaya <mariatta.wijaya at gmail.com>:
I'm fine with the delay. I've been thinking to implement the bot that will remind us when all the CI has been completed. So we don't have to wait, and won't forget about it.
Currently miss-islington does this only for the backport PRs made by miss-islington. I think it'll be useful to do that on other PRs too. (yes I'm aware GitLab does this but we are on GitHub) Mariatta Wijaya
- Previous message (by thread): [python-committers] AppVeyor is now required to pass on PRs
- Next message (by thread): [python-committers] AppVeyor is now required to pass on PRs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]