[python-committers] trivial tag on GitHub? (original) (raw)

Ethan Furman ethan at stoneleaf.us
Fri Jan 26 16:21:03 EST 2018

On 01/26/2018 01:09 PM, Ned Deily wrote:

On Jan 26, 2018, at 16:05, Ethan Furman <ethan at stoneleaf.us> wrote:

On 01/26/2018 09:28 AM, Mariatta Wijaya wrote:

So when the original PR didn't have a news entry, what should I have seen to alert me to that?

If a news entry is missing from the PR, the CI check at the bottom of the PR will fail. You should see the following: bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label found An example can be seen here (at least at the time I write this email) https://github.com/python/cpython/pull/5347 Okay, I see it in your example. Here's the PR I'm talking about: https://github.com/python/cpython/pull/5103 I see no NEWS commit, and no "missing news" alert. Did I misstep somewhere? It's all the way at the bottom, generated by blurb: Misc/NEWS.d/next/Library/2018-01-04-14-45-33.bpo-29237.zenYA6.rst https://github.com/python/cpython/pull/5103/files

Ah, thanks Ned, and everyone. So the takeaway is if I see something totally incomprehensible, it's probably the NEWS file. Also, I can't merge without a NEWS file. Good things. ;)

-- Ethan

More information about the python-committers mailing list