[Python-Dev] serious bug in new import X as Y code (original) (raw)

Thomas Wouters thomas@xs4all.net
Fri, 18 Aug 2000 22:56:07 +0200


On Fri, Aug 18, 2000 at 04:45:03PM -0400, Barry A. Warsaw wrote:

This is no different than if you change configure.in; you must commit both that file and the generated configure file.

Yes, but more critically so, since it'll screw up more than a couple of defines on a handful of systems :-) However, this particular change in the make process doesn't adress this at all. It would merely serve to mask this problem, in the event of someone commiting a change to Grammar but not to graminit.. The reasoning behind the change was "if you change Grammar/Grammar, and then type 'make', graminit. should be regenerated automatically, before they are used in other files." I thought the change was a small and reasonable one, but now I don't think so, anymore ;P On the other hand, perhaps the latest changes (not mine) fixed it for real.

But I still think that if this particular makefile setup is used in releases, 'pgen' should at least be made a tad less verbose.

-- Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!