[Python-Dev] Re: warning in initpyexpat (original) (raw)

Fred L. Drake, Jr. fdrake@beopen.com
Fri, 25 Aug 2000 13:36:53 -0400 (EDT)

Jeremy Hylton writes:

It is indeed the case that errors_module can be used without initialization. If PyString_FromString("pyexpat.errors") fails, you ignore the error and will immediately call PyModule_GetDict with an uninitialized variable.

I'll fix that.

I also wonder why the code that does this check is in its own set of curly braces; thus, the post to python-dev to discuss the style issue. Why did you do this? Is it approved Python style? It looks cluttered to me.

I don't like it either. ;) I just wanted a temporary variable, but I can declare that at the top of initpyexpat(). This will be corrected as well.

-Fred

-- Fred L. Drake, Jr. BeOpen PythonLabs Team Member