[Python-Dev] Re: [Python-checkins] python/dist/src/Modules readline.c, 2.72, 2.73 (original) (raw)

Michael Hudson mwh at python.net
Mon Aug 16 18:19:15 CEST 2004

Skip Montanaro <skip at pobox.com> writes:

Michael> A few small quibbles... >> + PyErrSetString(PyExcValueError, buf);

Michael> What's wrong with PyErrFormat()? Probably nothing. Michal's original patch was against 2.2.something. I don't know if that makes a difference or not. I'll fix it.

Thanks.

>> + PyDocSTRVAR(docremovehistory, _>> + "removehistory(pos) -> None\n_ Michael> ^^^^^^^^^^^^^^ This isn't the name in the PyMethodDef at the Michael> end...

That too. Michal had originally called them removehistory and replacehistory. I added "item" to the end of each so they were structurally more like the preexisting gethistoryitem, then conveniently missed the doc strings.

Fast work!

Cheers, mwh

-- Never meddle in the affairs of NT. It is slow to boot and quick to crash. -- Stephen Harris -- http://home.xnet.com/~raven/Sysadmin/ASR.Quotes.html

More information about the Python-Dev mailing list