WHUI! (was Re: [Python-Dev] Proposal: C API Macro to decref and set to NULL) (original) (raw)

Christian Tismer tismer at stackless.com
Fri Jul 16 00:51:28 CEST 2004

Tim Peters wrote:

[Jim Fulton]

I still don't like it, because it hides the return.

I'd rather do: if (self->foo != NULL && (vret = visit(self->foo, arg))) return vret; than VISIT(self->foo) I don't believe you <0.5 wink>. Here, rewrite this: VISIT(self->readline); VISIT(self->read); VISIT(self->file); VISIT(self->memo); VISIT(self->stack); VISIT(self->persfunc); VISIT(self->arg); VISIT(self->laststring); VISIT(self->findclass); return 0;

How about

     if ( 0 ||
       || VISIT(self->readline)
       || VISIT(self->read)
       || VISIT(self->file)
    )
    return 1;

-- chris

-- Christian Tismer :^) <mailto:tismer at stackless.com> Mission Impossible 5oftware : Have a break! Take a ride on Python's Johannes-Niemeyer-Weg 9a : Starship http://starship.python.net/ 14109 Berlin : PGP key -> http://wwwkeys.pgp.net/ work +49 30 89 09 53 34 home +49 30 802 86 56 mobile +49 173 24 18 776 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/

More information about the Python-Dev mailing list