[Python-Dev] [Python-checkins] r45321 - in python/trunk: Lib/test/test_traceback.py Lib/traceback.py Misc/NEWS (original) (raw)

Georg Brandl g.brandl at gmx.net
Thu Apr 13 09:17:44 CEST 2006

Tim Peters wrote:

[georg.brandl]

Author: georg.brandl Date: Wed Apr 12 23:14:09 2006 New Revision: 45321

Modified: python/trunk/Lib/test/testtraceback.py python/trunk/Lib/traceback.py python/trunk/Misc/NEWS Log: Patch #860326: traceback.formatexceptiononly() now prepends the exception's module name to non-builtin exceptions, like the interpreter itself does. And all the trunk buildbot runs have failed since, in at least testdecimal, testdoctest and testunpack. Please run tests before checking in.

Well, it's tempting to let the buildbots run the tests for you Honestly, I didn't realize that doctest relies on traceback. Running the test suite takes over half an hour on this box, so I decided to take a chance.

The 2.4 backport of this patch should be reverted, since it changes visible behavior (for example, all the 2.4 branch buildbot runs also fail now).

Right. That's too much of a behavior change.

Fine by me if we change the failing tests on the trunk to pass (noting that should have been done before checking in).

I'm not the one to decide, but at some time the traceback module should be rewritten to match the interpreter behavior.

Cheers, Georg

More information about the Python-Dev mailing list