[Python-Dev] threadsafe patch for asynchat (original) (raw)

Guido van Rossum guido at python.org
Wed Feb 8 00:05:38 CET 2006

IMO asynchat and asyncore are braindead. The should really be removed from the standard library. The code is 10 years old and represents at least 10-year-old thinking about how to do this. The amount of hackery in Zope related to asyncore was outrageous -- basically most of asyncore's guts were replaced with more advanced Zope code, but the API was maintained for compatibility reasons. A nightmare.

--Guido

On 2/6/06, "Martin v. Löwis" <martin at v.loewis.de> wrote:

Mark Edgington wrote: > Does anyone have any comments about applying the following patch to > asynchat?

That patch looks wrong. What does it mean to "run in a thread"? All code runs in a thread, all the time: sometime, that thread is the main thread. Furthermore, I can't see any presumed thread-unsafety in asynchat. Sure, there is a lot of member variables in asynchat which aren't specifically protected against mutual access from different threads. So you shouldn't be accessing the same asyncchat object from multiple threads. I cannot see why using a creating and using an asyncchat object in a thread that is not the main thread could cause any problems. I also cannot see how this patch could have significant effect on asynchat's behaviour when used in multiple threads. Regards, Martin

Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/guido%40python.org

-- --Guido van Rossum (home page: http://www.python.org/~guido/)

More information about the Python-Dev mailing list