[Python-Dev] Pervasive socket failures on Windows (original) (raw)

Tim Peters tim.peters at gmail.com
Fri Feb 10 22:14:38 CET 2006

[Scott Dial]

This begs the question then whether the check that is implemented has any relevance to any platform other than Linux. I am no portability guru, but I have to think there are other platforms where this patch will cause problems. For now at least, can we at least do some preprocessing magic to not use this code with Windows?

We have to gut this patch on Windows, because Python code using sockets on Windows no longer works. That can't stand. Indeed, I'm half tempted to revert the checkin right now since Python's test suite fails or hangs on Windows in test after test now. This at least blocks me from doing work I wanted to do (instead I spent the time allocated for that staring at test failures).

I suggest skipping the new crud conditionalized on a symbol like

Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE

The Windows pyconfig.h can #define that, and other platforms can ignore its possible existence. If it applies to some Unix variant too, fine, that variant can also #define it. No idea here what the story is on, e.g., Cygwin or OS2.

More information about the Python-Dev mailing list