[Python-Dev] Baffled by PyArg_ParseTupleAndKeywords modification (original) (raw)
M.-A. Lemburg mal at egenix.com
Tue Feb 14 09:09:56 CET 2006
- Previous message: [Python-Dev] Baffled by PyArg_ParseTupleAndKeywords modification
- Next message: [Python-Dev] Baffled by PyArg_ParseTupleAndKeywords modification
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Martin v. Löwis wrote:
M.-A. Lemburg wrote:
It's the consequences: nobody complains about tacking "const" on to a former honest-to-God "char *" argument that was in fact not modified, because that's not only helpful for C++ programmers, it's harmless for all programmers. For example, nobody could sanely object (and nobody did :-)) to adding const to the attribute-name argument in PyObjectSetAttrString(). Sticking to that creates no new problems for anyone, so that's as far as I ever went.
Well, it broke my C extensions... I now have this in my code: /* The keyword array changed to const char* in Python 2.5 */ #if PYVERSIONHEX >= 0x02050000 # define PyKEYWORDSSTRINGTYPE const char #else # define PyKEYWORDSSTRINGTYPE char #endif ... static PyKEYWORDSSTRINGTYPE *kwslist[] = {"yada", NULL}; ... You did not read Tim's message carefully enough. He wasn't talking about PyArgParseTupleAndKeywords at all. He only talked about changing char* arguments to const char*, e.g. in PyObjectSetAttrString. Did that break your C extensions also?
I did read Tim's post: sorry for phrasing the reply the way I did.
I was referring to his statement "nobody complains about tacking "const" on to a former honest-to-God "char *" argument that was in fact not modified".
Also: it's not me complaining, it's the compilers !
-- Marc-Andre Lemburg eGenix.com
Professional Python Services directly from the Source (#1, Feb 14 2006)
Python/Zope Consulting and Support ... http://www.egenix.com/ mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/
::: Try mxODBC.Zope.DA for Windows,Linux,Solaris,FreeBSD for free ! ::::
- Previous message: [Python-Dev] Baffled by PyArg_ParseTupleAndKeywords modification
- Next message: [Python-Dev] Baffled by PyArg_ParseTupleAndKeywords modification
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]