[Python-Dev] how bugfixes are handled? (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Fri Feb 17 00:21:26 CET 2006

Arkadiusz Miskiewicz wrote:

I wasn't, thanks for information.

Still few questions... one of developers/commiters reviews patch and commit it? Few developers has to review single patch?

As Neal says, a single committer can review and commit. However, non-committers can also review; this is the point of asking for patch reviews. In many cases, the initial patch will not be "good enough": it will lack documentation and test cases, it will contain bugs, not follow the code formatting guidelines, and it will make changes irrelevant to the issue being addressed ("gratuitous changes").

A reviewer is supposed to sort these all out, and then end up with a final recommendation ("accept" or "reject"). Of course, if it is going to be "reject", there is little point in making the submitter comply with formal criteria.

Ideally, a committer then will only have to read the entire review process, agree with it step-by-step, and commit the proposed change.

As a historical note: people doing a lot of reviews eventually end up as committers, just because it is easier for the other committers if they also do the final step.

Regards, Martin

More information about the Python-Dev mailing list