[Python-Dev] Another 2.5 bug candidate? (original) (raw)

Nick Maclaren nmm1 at cus.cam.ac.uk
Sun Jul 2 20:08:19 CEST 2006

"A.M. Kuchling" <amk at amk.ca> wrote:

http://www.python.org/sf/1488934 argues that Python's use of fwrite() has incorrect error checking; this most affects file.write(), but there are other uses of fwrite() in the core. It seems fwrite() can return N bytes written even if an error occurred, and the code needs to also check ferror(f->fp). At the last sprint I tried to assemble a small test case to exhibit the problem but failed. The reporter's test case uses SSH, and I did verify that Python does loop infinitely if executed under SSH, but a test case would need to work without SSH. Should this be fixed in 2.5? I'm nervous about such a change to error handling without a test case to add; maybe it'll cause problems on one of our platforms.

So would assembling a test case. NOTHING will cause ferror to return True that isn't classed as undefined behaviour, and therefore may fail on some platforms.

Regards, Nick Maclaren, University of Cambridge Computing Service, New Museums Site, Pembroke Street, Cambridge CB2 3QH, England. Email: nmm1 at cam.ac.uk Tel.: +44 1223 334761 Fax: +44 1223 334679

More information about the Python-Dev mailing list