[Python-Dev] patch #1454481 vs buildbot (original) (raw)
Andrew MacIntyre andymac at bullseye.apana.org.au
Mon Jun 5 12:13:14 CEST 2006
- Previous message: [Python-Dev] patch #1454481 vs buildbot
- Next message: [Python-Dev] Request for trackers to evaluate as SF replacement for Python development
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Tim Peters wrote:
#if THREADSTACKMIN < PTHREADSTACKMIN
assumes that the expansion of PTHREADSTACKMIN acts like a compile-time constant expression, but there's no such guarantee. http://cvs.opensolaris.org/source/xref/on/usr/src/head/limits.h shows that, on one version of Solaris, it's actually defined via #define PTHREADSTACKMIN ((sizet)sysconf(SCTHREADSTACKMIN)) That has a runtime value, but not a useful compile-time value. The only useful thing you can do with it in an #if expression is defined(PTHREADSTACKMIN).
Ok.
2. I don't know what to make of the failure of testthreading on Linux, as testthread succeeds as far as I could see. These tests succeed on my FreeBSD box and also appear to be succeeding on the Windows buildbots. Not all pthreads-using builds fail, and not all failing pthreads-using builds fail in the same way. Welcome to pthreads on Linux ;-) BTW, this sucks: testthread /home/buildbot/Buildbot/trunk.baxter-ubuntu/build/Lib/test/testthread.py:138: RuntimeWarning: thread stack size of 0x1000 bytes not supported thread.stacksize(tss) That's from a successful run. RuntimeWarning really doesn't make sense for a failing operation. This should raise an exception (xyzError, not xyzWarning), or a failing stacksize() should return an error value after ensuring the original stack size is still in effect.
Fair enough.
{...}
If PyThreadstartnewthread() fails in any way (like,pthreadattrsetstacksize() failing), ""can't start new thread" is the error we see.
The difference between testthread and testthreading here is that only testthreading asks for a 16MB stack; testthread doesn't ask for a stack larger than 4MB.
Thanks for the analysis!
Until all this gets resolved, I strongly suggest reverting this patch (if you don't, someone else will ...) and hammering out the problems on a new branch instead. See python-dev email from yesterday for how to force a buildbot slave to build a branch.
I see that you've already reverted this - Thanks & sorry I couldn't get to it quickly.
Regards, Andrew.
Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac at bullseye.apana.org.au (pref) | Snail: PO Box 370 andymac at pcug.org.au (alt) | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
- Previous message: [Python-Dev] patch #1454481 vs buildbot
- Next message: [Python-Dev] Request for trackers to evaluate as SF replacement for Python development
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]