[Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile) (original) (raw)
Ronald Oussoren ronaldoussoren at mac.com
Tue Jun 13 15:59:05 CEST 2006
- Previous message: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)
- Next message: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 13-jun-2006, at 15:08, Aahz wrote:
On Tue, Jun 13, 2006, Ronald Oussoren wrote:
There are two backward incompatbile changes, both minor. First of all ZipInfo will lose the fileoffset attribute because calculating it when opening a zipfile is very expensive (it basically requires a full scan of the zipfile). This should be harmless, I couldn't come up with a usecase other then reimplementing the read method outside of zipfile. Not knowing anything about this, why not implement fileoffset as a property?
That is possible but would introduce a link from ZipInfo instances to
Zipfile instances and would therefore introduce a cycle. As Zipfile
has a del method that's not something I wanted to do.
Ronald
-------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2157 bytes Desc: not available Url : http://mail.python.org/pipermail/python-dev/attachments/20060613/b3586fbe/attachment-0001.bin
- Previous message: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)
- Next message: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]