[Python-Dev] Does Python/Python-ast.c need to be checked in? (original) (raw)

Brett Cannon brett at python.org
Mon Feb 12 04:53:22 CET 2007


On 2/11/07, "Martin v. Löwis" <martin at v.loewis.de> wrote:

Brett Cannon schrieb: > On 2/11/07, skip at pobox.com <skip at pobox.com> wrote: >> Someone checked in Parser/Python.asdl. After rebuilding Subversion tells me >> that Python/Python-ast.c has been modified. I assume the two are related. >> Did whoever checked in the former need to check in the latter > > Yeah, sorry about that. It took a make distclean for it to get > regenerated for me. I checked in the updated version.

Actually, the regenerating should happen immediately after commit, as this bumps the revision number of the asdl file. This means you have to make two commits per AST grammar change: one to change the grammar, and the other to update the regenerated file.

Revision 53751 adds a comment to Python-ast.c about this now, along with putting version in the header as well.

-Brett



More information about the Python-Dev mailing list