[Python-Dev] PEP: Post import hooks (original) (raw)

Phillip J. Eby pje at telecommunity.com
Fri Jan 11 01:54:25 CET 2008

At 01:47 AM 1/11/2008 +0100, Christian Heimes wrote:

Phillip J. Eby wrote: > At 11:45 PM 1/10/2008 +0100, Christian Heimes wrote: >> In my version a hook is immediately called when the the registry value >> is set to None. When a hook is registered for a module during the >> execution of the callback then the hook is fired directly and not after >> the existing hooks are called. Is this a problem for you? > > Yes, because it violates the invariant that hooks for a given module > are called in the same order that they were registered in.

Please check the changes and the new unit test in r59902 ( http://svn.python.org/view?rev=59902&view=rev ). Are you satisfied with the ordering or do you think I should queue the hooks for already loaded modules?

As I said above, calling the callbacks immediately is a problem, because it leads to significantly less predictability (and therefore control) of callback order.

More information about the Python-Dev mailing list