[Python-Dev] smtplib violates SMTP spec (original) (raw)
Felix Schwarz felix.schwarz at oss.schwarz.eu
Sun Feb 15 17:38:44 CET 2009
- Previous message: [Python-Dev] draft 3.1 release schedule
- Next message: [Python-Dev] smtplib violates SMTP spec
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
I would like to get attention to issue 4142 [1] which was filed several months ago. This is about a clear bug in smtplib's SMTP implementation which is probably present since (at least) Python 1.5.
When re-using an smtplib.SMTP instance for a second connection, smtplib does not send another HELO/EHLO which is a clear violation of the SMTP specification.
I built a small patch (changes only 2 lines) but I'm unable to write a unit test for this easily because:
- Python's smtpd does not check if HELO/EHLO was received before MAIL FROM
- Therefore any extension of test_smtplib would need some patches to check this also.
However, the patch is very small so it is very easy to test this manually. Just connect to a real world smtp (Exim is best because it is quite strict when it comes to SMTP verbs).
fs
[1] http://bugs.python.org/issue4142
- Previous message: [Python-Dev] draft 3.1 release schedule
- Next message: [Python-Dev] smtplib violates SMTP spec
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]