[Python-Dev] PEP 3144 review. (original) (raw)

R. David Murray rdmurray at bitdance.com
Tue Sep 29 21:31:31 CEST 2009

On Tue, 29 Sep 2009 at 15:24, R. David Murray wrote:

There's one place in this code where the inclusion of the 'ip' information in the IPNetwork class could have been used. In the line that allows ICMP traffic to the router's outside port, I could have written 'inside.ip' instead of interfaces['inside'].ip. I think that would have confused me when I came back to read the code later, though, since 'inside' is otherwise a network object.

Er, that should have been 'outside' in both the code and the paragraph above, of course. Which would also have run but produced incorrect output...make of that what you will :)

--David

More information about the Python-Dev mailing list