[Python-Dev] Anyone can do patch reviews (original) (raw)

Tres Seaver tseaver at palladion.com
Tue Apr 27 21:23:19 CEST 2010

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Antoine Pitrou wrote:

Tres Seaver <tseaver palladion.com> writes:

This is an excellent set of guidelines. The only drawback I see here is that the current VCS situation makes doing the review more tedious than it should be, especially for non-committers. Or maybe the Hg mirrors are truly up-to-date and working? Last I looked, they were lagging or unavailable. If you only a review a patch (rather than say maintain and evolve it), there's no point in using hg rather than SVN.

Hmm, it feels exactly the other way around to me: working with the DVCS tools while reviewiing a patch allows me to be more productive (e.g., using 'bzr shelve' or the equivalent hg subcommand).

Making a local branch / clone for each issue also feels more natural than working in a read-only SVN checkout.

However, the mirrors are most of the time alive and up-to-date (sync period is around 5 minutes): http://code.python.org/hg

That was the URL I was trying to work with: it has been a couple of months since I last tried, however.

(perhaps you're thinking about http://hg.python.org/, which is an experimental conversion of the SVN repo, not really meant for daily use)

Tres. - --

Tres Seaver +1 540-429-0999 tseaver at palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvXOacACgkQ+gerLs4ltQ6ZTwCfQ96RYQ6h/zdMOnFUJU3MkSC1 +o8An2CqK7fbpiCM3gBWZuRReG46xv+U =iWug -----END PGP SIGNATURE-----

More information about the Python-Dev mailing list