[Python-Dev] Anyone can do patch reviews (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Tue Apr 27 23:47:52 CEST 2010
- Previous message: [Python-Dev] Anyone can do patch reviews (was: Enhanced tracker privileges...)
- Next message: [Python-Dev] Anyone can do patch reviews
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Ezio Melotti wrote:
When I'm writing the patch it's usually easy, I write the tests, see that they fail, write the fix, see that they pass. When I'm reviewing the patch, I apply the patch, see that the tests pass, svn revert the fix, check that they fail. Most of the patches affect just a couple of files, so applying the whole patch and then revert is usually trivial and probably easier than having to deal with two separate files for patch and tests.
This would be pretty close to my typical workflow as well (looks at list of assigned bugs that hasn't moved in weeks well, it is the workflow when I actually do some Python coding...)
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] Anyone can do patch reviews (was: Enhanced tracker privileges...)
- Next message: [Python-Dev] Anyone can do patch reviews
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]