[Python-Dev] [Python-checkins] r86817 - python/branches/py3k-stat-on-windows/Lib/test/test_shutil.py (original) (raw)

Hirokazu Yamamoto ocean-city at m2.ccsnet.ne.jp
Thu Dec 2 16:50:51 CET 2010


On 2010/11/27 5:31, Brian Curtin wrote:

On Fri, Nov 26, 2010 at 14:18, Hirokazu Yamamoto<ocean-city at m2.ccsnet.ne.jp

wrote:

On 2010/11/27 5:02, Brian Curtin wrote:

We briefly chatted about this on the os.link feature issue, but I never found a way around it.

How about implementing os.path.samefile in Modules/posixmodule.c like this? http://bugs.python.org/file19262/py3kfixkillpythonforshortpath.patch # I hope this works. That's almost identical to what the current os.path.sameopenfile is. Lib/ntpath.py opens both files, then compares them via getfileinformation. That function is implemented to take in a file descriptor, call GetFileInformationByHandle with it, then returns a tuple of dwVolumeSerialNumber, nFileIndexHigh, and nFileIndexLow.

Yes. Difference is, file object cannot represent directory, and probably FILE_FLAG_BACKUP_SEMANTICS makes it faster to open file.



More information about the Python-Dev mailing list