[Python-Dev] Rietveld integration into Roundup (original) (raw)
Antoine Pitrou solipsis at pitrou.net
Sat Oct 2 23:01:51 CEST 2010
- Previous message: [Python-Dev] We should be using a tool for code reviews
- Next message: [Python-Dev] Patch making the current email package (mostly) support bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Le samedi 02 octobre 2010 à 22:55 +0200, "Martin v. Löwis" a écrit :
> 2) if I look at http://bugs.python.org/issue9962, only the second patch > of all three has been enabled for review. Yet they were all created > through "svn diff" against a recent py3k checkout. They had both the same problem: it could figure out the revision number the patch applied to (e.g. 85039), but not the branch that this revision is for. That's because the revision is 85039, and in r85039, only /peps got modified. I see... so the revision number is mostly useless when trying to identify the branch. You should be able to fix this by manually filling out the branch on the file. I'll have to come up with a better way to determine the branch which a patch was created on. Perhaps going back in history and taking the first branch where the patch cleanly applies can do the trick.
I think a heuristic would be to try py3k HEAD first. That's what most patches are supposed to work against.
Regards
Antoine.
- Previous message: [Python-Dev] We should be using a tool for code reviews
- Next message: [Python-Dev] Patch making the current email package (mostly) support bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]