[Python-Dev] We should be using a tool for code reviews (original) (raw)

Daniel Stutzbach daniel at stutzbachenterprises.com
Wed Sep 29 20:50:30 CEST 2010

On Wed, Sep 29, 2010 at 1:41 PM, Antoine Pitrou <solipsis at pitrou.net> wrote:

He, several of us would like it too (although for short patches it doesn't really make a difference), but what's missing is some kind of Roundup integration. Something as trivial as a "start review" button in front of every uploaded patch file would do the trick; it has been suggested several times already, but what's needed is someone to write the code :)

Most patches won't import cleanly into Rietveld, because the patch typical does not contain precise information about the base revision for the patch.

How about the opposite approach: make a Python-specific version of upload.py that lets the user attach the patch to an issue with an optional message?

-- Daniel Stutzbach, Ph.D. President, Stutzbach Enterprises, LLC <http://stutzbachenterprises.com/> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20100929/4ab1354b/attachment-0001.html>

More information about the Python-Dev mailing list