[Python-Dev] We should be using a tool for code reviews (original) (raw)

Fred Drake fdrake at acm.org
Thu Sep 30 00:19:41 CEST 2010

On Wed, Sep 29, 2010 at 5:57 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:

Would it be possible to sync up the reitveld issue numbers with the roundup ones if you did that? Or would the fact that a single issue can have multiple attached patches prevent that?

Another quirk would be that often several pieces are uploaded which really constitute a single change; often docs and/or tests are provided separately, just because we've had to go back and ask for them. Sometimes they're provided by a separate contributor.

Keeping the numbers aligned could probably be done based on the file number containing the patch, assuming those are never reused (I don't think they are, but haven't dug deep enough into roundup).

  -Fred

-- Fred L. Drake, Jr.    "A storm broke loose in my mind."  --Albert Einstein

More information about the Python-Dev mailing list