[Python-Dev] We should be using a tool for code reviews (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Thu Sep 30 17:07:05 CEST 2010

On Thu, 30 Sep 2010 14:52:18 -0000 exarkun at twistedmatrix.com wrote:

> >Regardless of the tool(s) used, code reviews are a fantastic >equalizer. If you have long time, experienced developers "submitting" >to the same rules that newer contributors have to follow then it helps >remove the idea that there is special treatment occurring.

Of course, this is only true if the core developers do submit to the same rules. Is anyone proposing that current core committers have all their work reviewed before it is accepted? (I am strongly in favor of this, but I don't think many core committers are.)

While I agree with non-trivial patches being posted for review, I don't agree that an actual review should happen in order for a patch to be committed. That's unless we get 10x the number of reviewers we currently have.

(and you certainly know by experience that I would be glad to have reviews on my patches, especially the network-related ones ;-))

Regards

Antoine.

More information about the Python-Dev mailing list