[Python-Dev] We should be using a tool for code reviews (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Thu Sep 30 17:51:07 CEST 2010

Am 30.09.2010 17:40, schrieb Senthil Kumaran:

On Thu, Sep 30, 2010 at 9:52 AM, <exarkun at twistedmatrix.com> wrote:

Of course, this is only true if the core developers do submit to the same rules. Is anyone proposing that current core committers have all their work reviewed before it is accepted? For large patches it is good idea. But enforcing it for smaller patches may cost us more time for each commit.

I think the supporters of code review readily accept that: in return for the higher effort, they say, we also get more quality.

So it's really a quality vs. quantity thing. It would be easy to just commit all patches that are uploaded to roundup, but of course, it would horribly break Python. With mandatory code review, even less patches get reviewed than today.

Regards, Martin

More information about the Python-Dev mailing list