[Python-Dev] cpython: Add _PyUnicode_UTF8() and _PyUnicode_UTF8_LENGTH() macros (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Sat Oct 1 17:47:26 CEST 2011

Am 01.10.2011 17:18, schrieb Antoine Pitrou:

On Sat, 01 Oct 2011 16:53:44 +0200 victor.stinner <python-checkins at python.org> wrote:

http://hg.python.org/cpython/rev/4afab01f5374 changeset: 72565:4afab01f5374 user: Victor Stinner <victor.stinner at haypocalc.com> date: Sat Oct 01 16:48:13 2011 +0200 summary: Add PyUnicodeUTF8() and PyUnicodeUTF8LENGTH() macros

* Rename existing PyUnicodeUTF8() macro to PyUnicodeUTF8() Wouldn't this be better called PyUnicodeASUTF8()?

No. _AS_UTF8 would imply that some conversion function is called. In this case, it's a pure structure accessor macro, that may give NULL if the pointer is not yet filled out.

It's not called Py_AS_TYPE, but Py_TYPE; likewise not PyWeakref_AS_OBJECT, but PyWeakref_GET_OBJECT. In this case, PyUnicode_GET_UTF8 might have been an alternative.

Regards, Martin

More information about the Python-Dev mailing list