[Python-Dev] [Python-checkins] cpython: fix compiler warnings (original) (raw)

Vlad Riscutia riscutiavlad at gmail.com
Wed Oct 5 00:30:54 CEST 2011

Why does the function even return a value? As Benjamin said, it is just a bunch of asserts with return 1 at the end.

I believe another way you can get rid of "statement with no effect" is to cast return value to void, like (void)_PyUnicode_CHECK(unicode).

Thank you, Vlad

On Tue, Oct 4, 2011 at 4:57 AM, Benjamin Peterson <benjamin at python.org>wrote:

2011/10/4 Victor Stinner <victor.stinner at haypocalc.com>: > Le 04/10/2011 01:34, benjamin.peterson a écrit : >> >> http://hg.python.org/cpython/rev/afb60b190f1c >> changeset: 72633:afb60b190f1c >> user: Benjamin Peterson<benjamin at python.org> >> date: Mon Oct 03 19:34:12 2011 -0400 >> summary: >> fix compiler warnings >> >> +++ b/Objects/unicodeobject.c >> @@ -369,6 +369,12 @@ >> } >> return 1; >> } >> +#else >> +static int >> +PyUnicodeCheckConsistency(void *op) >> +{ >> + return 1; >> +} >> #endif > > Oh no, please don't do that. Calling PyUnicodeCheckConsistency() is > reserved to debug builds. In release mode, we should not check string > consistency (it would slow down Python).

It should be optimized out. > > Yes, there was a warning: > > Objects/unicodeobject.c:539:13: warning: statement with no effect > PyUnicodeCHECK(unicode); > > I added these checks recently to ensure that strings are consistent just > before exiting (to help me to track down a bug). > > The right fix is just to replace PyUnicodeCHECK(unicode) by > assert(PyUnicodeCHECK(unicode)). But PyUnicodeCheckConsistency is just a string of assertions. What sense does it make to check the return value?

-- Regards, Benjamin

Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/riscutiavlad%40gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20111004/fde24094/attachment.html>

More information about the Python-Dev mailing list