[Python-Dev] check for PyUnicode_READY look backwards (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Fri Oct 7 00:20:00 CEST 2011

Am 06.10.11 14:57, schrieb Amaury Forgeot d'Arc:

Hi,

with the new Unicode API, there are many checks like: + if (PyUnicodeREADY(*filename)) + goto handleerror;

I think you are misinterpreting what you are seeing. There are not many such checks. Of the PyUnicode_READY checks, 106 take the form

 if (PyUnicode_READY(foo) == -1)
      return NULL;

30 tests take the form that you mention.

I believe all of those have been added by Victor, who just didn't follow the convention.

So, Victor: please correct them.

Regards, Martin

More information about the Python-Dev mailing list