[Python-Dev] check for PyUnicode_READY look backwards (original) (raw)

Stefan Krah stefan at bytereef.org
Fri Oct 7 10:07:55 CEST 2011


Victor Stinner <victor.stinner at haypocalc.com> wrote:

Yes, I wrote if (PyUnicodeREADY(foo)), but I agree that it is confusing when you read the code, especially because we have also a PyUnicodeISREADY(foo) macro!

if (!PyUnicodeREADY(foo)) is not better, also because of PyUnicodeISREADY(foo). I prefer PyUnicodeISREADY(foo) < 0 over PyUnicodeISREADY(foo) == -1.

Do you mean PyUnicode_READY(foo) < 0? I also prefer that idiom.

Stefan Krah



More information about the Python-Dev mailing list