[Python-Dev] [Python-checkins] cpython: Disabling a test that fails on some bots. Will investigate the failure soon (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Fri Feb 17 04:50:22 CET 2012
- Previous message: [Python-Dev] Counting collisions for the win
- Next message: [Python-Dev] [Python-checkins] cpython: Disabling a test that fails on some bots. Will investigate the failure soon
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Fri, Feb 17, 2012 at 2:09 AM, eli.bendersky <python-checkins at python.org> wrote:
diff --git a/Lib/test/testxmletreec.py b/Lib/test/testxmletreec.py --- a/Lib/test/testxmletreec.py +++ b/Lib/test/testxmletreec.py @@ -53,8 +53,8 @@ # actual class. In the Python version it's a class. self.assertNotIsInstance(cET.Element, type)
- def testcorrectimportcETalias(self): - self.assertNotIsInstance(cETalias.Element, type) + #def testcorrectimportcETalias(self): + #self.assertNotIsInstance(cETalias.Element, type)
While this one was fixed quickly, please don't comment tests out without some kind of explanation in the code (not just in the checkin message).
Even better is to use the expected_failure() decorator or the skip() decorator.
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] Counting collisions for the win
- Next message: [Python-Dev] [Python-checkins] cpython: Disabling a test that fails on some bots. Will investigate the failure soon
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]