[Python-Dev] cpython: Issue 14814: Correctly return NotImplemented from ipaddress._BaseNetwork.eq (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Sat Jul 7 17🔞22 CEST 2012
- Previous message: [Python-Dev] cpython: Issue 14814: Correctly return NotImplemented from ipaddress._BaseNetwork.__eq__
- Next message: [Python-Dev] cpython (3.2): Fix issue14826 - make urllib.request.Request quoted url consistent with
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Sun, Jul 8, 2012 at 12:59 AM, Nick Coghlan <ncoghlan at gmail.com> wrote:
On Sat, Jul 7, 2012 at 11:55 PM, Antoine Pitrou <solipsis at pitrou.net> wrote:
I think the isinstance() test was correct. If you have an object which duck-types IPNetwork, you probably want its eq to be called, not yours. This change was just to bring IPNetwork in line with the other types in the module and to stop it throwing TypeError itself, which meant the RHS was never even getting a chance to affect the result.
Hmm, I just noticed the lt implementations still throw TypeError directly (at least in the IPNetwork case). Looks like some more cleanups are still needed in this area :P
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] cpython: Issue 14814: Correctly return NotImplemented from ipaddress._BaseNetwork.__eq__
- Next message: [Python-Dev] cpython (3.2): Fix issue14826 - make urllib.request.Request quoted url consistent with
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]