[Python-Dev] test_hashlib (original) (raw)
Kristján Valur Jónsson kristjan at ccpgames.com
Sat Jul 21 23:29:50 CEST 2012
- Previous message: [Python-Dev] four easy documentation patches
- Next message: [Python-Dev] test_hashlib
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I was hit by this today.
in test_hashlib.py there is this:
def test_unknown_hash(self):
self.assertRaises(ValueError, hashlib.new, 'spam spam spam spam spam')
self.assertRaises(TypeError, hashlib.new, 1)but in hashlib.py, there is this code:
except ImportError:
pass # no extension module, this hash is unsupported.raise ValueError('unsupported hash type %s' % name)
The code will raise ValueError when int(1) is passed in, but the unittests expect a TypeError.
So, which is correct?
K -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20120721/62747a7b/attachment.html>
- Previous message: [Python-Dev] four easy documentation patches
- Next message: [Python-Dev] test_hashlib
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]