[Python-Dev] venv scripts for fish and csh shells (original) (raw)
Andrew Svetlov andrew.svetlov at gmail.com
Sun Jul 22 18:10:59 CEST 2012
- Previous message: [Python-Dev] venv scripts for fish and csh shells
- Next message: [Python-Dev] venv scripts for fish and csh shells
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Georg, sorry, I've committed it before you answered.
If you want, I will revert it back. But, please, describe me why those scripts are to late for 3.3? I strongly checked correctness of both activation script for fish and csh/tsch shells. Works fine.
It's not new feature, it is just extending support to csh and fish shells. Virtualenv (base for venv) already contains this activation scripts. I just converted those files to venv with replacing virtualenv specific environment variables to schema supported by venv. I see nothing bad for adding to venv support for fish and csh as well as already supported bash/zsh
Say again, I triple checked correctness of added scripts. With defining VIRTUAL_ENV_DISABLE_PROMPT as well as without it. My addition is safe, trivial, correct and it is not new feature — just fixing of missing support for widely used shells.
Anyway. You are Release Manager — the main person for 3.3 release. If you feel what my changes is potentially dangerous and should be removed from 3.3 — I'll do it. But, please, do benevolent.
On Sun, Jul 22, 2012 at 6:21 PM, Georg Brandl <g.brandl at gmx.net> wrote:
These are new features, please do not commit before 3.3 is released.
Georg On 07/22/2012 02:12 AM, Andrew Svetlov wrote: I created http://bugs.python.org/issue15417 with required activation scripts. If there are no objections I like to commit it after, say, three days.
On Thu, Jul 19, 2012 at 7:31 PM, Carl Meyer <carl at oddbird.net> wrote: On 07/19/2012 10:26 AM, Andrew Svetlov wrote: virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only?
No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't commit said patch, so it might be good to hear if Vinay has a different opinion). Carl
Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com
Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com
-- Thanks, Andrew Svetlov
- Previous message: [Python-Dev] venv scripts for fish and csh shells
- Next message: [Python-Dev] venv scripts for fish and csh shells
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]