[Python-Dev] [Python-checkins] cpython: avoid unitialized memory (original) (raw)

Benjamin Peterson benjamin at python.org
Fri May 4 17:06:16 CEST 2012


2012/5/4 Eric V. Smith <eric at trueblade.com>:

On 5/4/2012 1:14 AM, benjamin.peterson wrote:

http://hg.python.org/cpython/rev/b0deafca6c02 changeset:   76743:b0deafca6c02 user:        Benjamin Peterson <benjamin at python.org> date:        Fri May 04 01:14:03 2012 -0400 summary: avoid unitialized memory

files: Modules/posixmodule.c |  2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -3576,7 +3576,7 @@  splitpylongtosandns(PyObject *pylong, timet *s, long *ns)  {  int result = 0; -    PyObject *divmod; +    PyObject *divmod = NULL;  divmod = PyNumberDivmod(pylong, billion); How is that uninitialized if it's being set on the next line?

It was a misreading on my part.

-- Regards, Benjamin



More information about the Python-Dev mailing list