[Python-Dev] [Python-checkins] cpython: Issue #14716: Change integer overflow check in unicode_writer_prepare() (original) (raw)
Victor Stinner victor.stinner at gmail.com
Mon May 7 23:51:48 CEST 2012
- Previous message: [Python-Dev] [Python-checkins] cpython: Issue #14716: Change integer overflow check in unicode_writer_prepare()
- Next message: [Python-Dev] [Python-checkins] cpython: Issue #14716: Change integer overflow check in unicode_writer_prepare()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
However, it's not my fault. I suggested
newlen < (PYSSIZETMAX -_ _PYSSIZETMAX / 5)
and notnewlen <= (PYSSIZETMAX - PYSSIZETMAX /_ _5)
. In this case, there is no overflow.
Oh. I didn't understand why you replaced <= by <, and so I used <=.
Anyway, I reverted the change for all reasons listed in this thread.
Victor
- Previous message: [Python-Dev] [Python-checkins] cpython: Issue #14716: Change integer overflow check in unicode_writer_prepare()
- Next message: [Python-Dev] [Python-checkins] cpython: Issue #14716: Change integer overflow check in unicode_writer_prepare()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]