[Python-Dev] cpython: Implemented PEP 405 (Python virtual environments). (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Sat May 26 10:10:02 CEST 2012


On Sat, 26 May 2012 04:48:49 +0200 vinay.sajip <python-checkins at python.org> wrote:

+syshome = getattr(sys, 'home', None) +if syshome and os.name == 'nt' and syshome.lower().endswith('pcbuild'): + syshome = os.path.dirname(syshome)

What about pcbuild/amd64? Does this work on 64-bit builds?

+syshome = getattr(sys, 'home', None) +if syshome and os.name == 'nt' and syshome.lower().endswith('pcbuild'): + syshome = os.path.dirname(syshome)

Same question here.

+#!/usr/bin/env python

I don't think there should be a shebang line in a test file.

+# +# Copyright 2011 by Vinay Sajip. All Rights Reserved. +# +# Permission to use, copy, modify, and distribute this software and its +# documentation for any purpose and without fee is hereby granted, +# provided that the above copyright notice appear in all copies and that +# both that copyright notice and this permission notice appear in +# supporting documentation, and that the name of Vinay Sajip +# not be used in advertising or publicity pertaining to distribution +# of the software without specific, written prior permission. +# VINAY SAJIP DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING +# ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL +# VINAY SAJIP BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR +# ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER +# IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT +# OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

Why the copyright boilerplate?

+# Use with a Python executable built from the Python fork at +# +# https://bitbucket.org/vinay.sajip/pythonv/ as follows:

This needs to be updated.

+# You'll need an Internet connection (needed to download distributesetup.py). +# +# The script will change to the environment's binary directory and run +# +# ./python distributesetup.py

[...]

+# This class will not be included in Python core; it's here for now to

Well... either the comment should be fixed or the class removed.

+ # XXX This option will be removed.

+ # XXX This will be changed to EnvBuilder

Same here.

diff --git a/Lib/venv/scripts/nt/pysetup3.exe b/Lib/venv/scripts/nt/pysetup3.exe new file mode 100644 index 0000000000000000000000000000000000000000..3f3c09ebc8e55f4ac3379041753cb34daef71892 GIT binary patch

What's this file and how was it compiled?

Regards

Antoine.



More information about the Python-Dev mailing list