[Python-Dev] Split unicodeobject.c into subfiles? (original) (raw)

Benjamin Peterson benjamin at python.org
Fri Oct 5 00:11:34 CEST 2012


2012/10/4 Victor Stinner <victor.stinner at gmail.com>:

2012/10/4 Benjamin Peterson <benjamin at python.org>:

2012/10/4 Victor Stinner <victor.stinner at gmail.com>:

I only see one argument against such refactoring: it will be harder to backport/forwardport bugfixes.

I imagine it could also prevent inlining of hot paths. It depends how the code is compiled. The stringlib is splitted in many .h files, but it is able to use PyLOCALINLINE. If the code is grouped correctly, we may not loose any nice optimization at all. FYI #include "test.c" is allowed in C ;-)

Yes, but then compilation won't be any faster. ;)

-- Regards, Benjamin



More information about the Python-Dev mailing list