[Python-Dev] Force to use Py_CLEAR and Py_VISIT in example for Python extending (original) (raw)
Benjamin Peterson benjamin at python.org
Sat Feb 9 14:54:20 CET 2013
- Previous message: [Python-Dev] Force to use Py_CLEAR and Py_VISIT in example for Python extending
- Next message: [Python-Dev] Force to use Py_CLEAR and Py_VISIT in example for Python extending
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
2013/2/9 Andrew Svetlov <andrew.svetlov at gmail.com>:
For now http://docs.python.org/3/extending/newtypes.html#supporting-cyclic-garbage-collection at first the doc demonstrate long way than note PyCLEAR and PyVISIT macroses.
I like to remove code similar to if (self->first) { vret = visit(self->first, arg); if (vret != 0) return vret; } and tmp = self->first; self->first = NULL; PyXDECREF(tmp); and replace those to PyVISIT and PyCLEAN. I think we have to demonstrate best practices in our examples. Let's py2.7 branch live untouched, change only docs for python 3.x Any objections?
IMO, it's fine if you change 2.7, too.
-- Regards, Benjamin
- Previous message: [Python-Dev] Force to use Py_CLEAR and Py_VISIT in example for Python extending
- Next message: [Python-Dev] Force to use Py_CLEAR and Py_VISIT in example for Python extending
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]