[Python-Dev] [Python-checkins] cpython: Provide a more readable representation of socket on repr(). (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Wed Nov 13 13:26:07 CET 2013
- Previous message: [Python-Dev] [Python-checkins] cpython: Provide a more readable representation of socket on repr().
- Next message: [Python-Dev] Restoring the aliases for the non-Unicode codecs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 13 November 2013 08:52, Victor Stinner <victor.stinner at gmail.com> wrote:
Hi Giampaolo,
You forgot to update tests after your change in repr(socket). Tests are failing on buildbots, just one example: ====================================================================== FAIL: testrepr (test.testsocket.GeneralModuleTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/test/testsocket.py", line 653, in testrepr self.assertIn('family=%i' % socket.AFINET, repr(s)) AssertionError: 'family=2' not found in "<socket.socket fd=22,_ _family=AddressFamily.AFINET, type=SocketType.SOCKSTREAM, proto=0,_ _laddr=('0.0.0.0', 0)>"
I fixed this to turn the buildbots green again before committing the codec error handling changes.
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] [Python-checkins] cpython: Provide a more readable representation of socket on repr().
- Next message: [Python-Dev] Restoring the aliases for the non-Unicode codecs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]